Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StartOf Week #71

Closed
AminTaghikhani opened this issue Apr 21, 2019 · 2 comments
Closed

StartOf Week #71

AminTaghikhani opened this issue Apr 21, 2019 · 2 comments
Labels
bug Fixed In Develop Branch

Comments

@AminTaghikhani
Copy link

Hi,
At first, I wanted to thank you for this awesome library!

I'm writing to tell you that I've found a bug in this library.
I use startOf('week') to get the start of this week, but there is a bug in this function.
when the month changes, startOf('week') returns startOf('day') data.

For example, today is
Sunday Ordibehesht 1st
and the start of this week is
Saturday Farvardin 31st.
But startOf('week') returns
Sunday Ordibehest 1st,
not Saturday Farvardin 31st.

my library version: v1.0.5
@babakhani
Copy link
Owner

@AminTaghikhani
you can test the new RC version.
npm install persian-date@next

@AminTaghikhani
Copy link
Author

AminTaghikhani commented May 7, 2019 •
edited
Loading

@babakhani

Thanks, fixed.

When is this version released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixed In Develop Branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@babakhani @AminTaghikhani