Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel-loader to use the async version of babel.transform #532

Closed
loganfsmyth opened this issue Nov 9, 2017 · 5 comments
Closed

Comments

@loganfsmyth
Copy link
Member

Like babel/babel#6784, but for babel-loader.

This one probably won't be as difficult since there is less complex surrounding logic.

@michael-ciniawsky
Copy link
Contributor

It's babel.transform(code, options, (err, result) => result) for async usage ?

@danez
Copy link
Member

danez commented Nov 11, 2017

We need to ensure, that we set the peer deps then correct for babel to be >=beta.X where X is the number where it gets released.

@michael-ciniawsky
Copy link
Contributor

There seems to be no async version of babel.transform ? Only babel.transformFile works async. Maybe I'm doing something wrong ¯_(ツ)_/¯

@loganfsmyth
Copy link
Member Author

It's babel.transform(code, options, (err, result) => result) for async usage ?

That is correct. That was added in the PR referenced in the linked issue, so it has not been published yet. When we get a @babel/core@7.0.0-beta.32 it'll be in there.

@loganfsmyth
Copy link
Member Author

This is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants