Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any version of webpack as a peerDependency #550

Merged
merged 2 commits into from
Jan 12, 2018

Conversation

lencioni
Copy link
Contributor

@lencioni lencioni commented Dec 7, 2017

Webpack 4 alpha has been released. In preparation for v4,
it seems reasonable to change this to allow *. This should cut
down on maintenance and avoid unnecessarily blocking folks
from updating going forward.

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: peerDependency change

What is the current behavior? (You can also link to an open issue here)
Cannot be used with Webpack 4 alpha

What is the new behavior?
Can be used with Webpack 4 alpha

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the following...

  • Impact:
  • Migration path for existing applications:
  • Github Issue(s) this is regarding:

Other information:
It would be nice to put out a release of babel-loader that allows any version of webpack and also works with Babel 6.

Webpack 4 alpha has been released. In preparation for v4,
it seems reasonable to change this to allow `*`. This should cut
down on maintenance and avoid unnecessarily blocking folks
from updating going forward.
@danez
Copy link
Member

danez commented Jan 7, 2018

Can you please change this to >= 2 that is what it should be right now, as 1.x is not supported and will not work.

@danez danez merged commit 40552b6 into babel:master Jan 12, 2018
@danez
Copy link
Member

danez commented Jan 12, 2018

Thank you very much.

@loganfsmyth
Copy link
Member

Is using a range like this a good idea? Using * is bad practice and I feel like >=2 isn't better, future Webpack versions could still easily break things if they wanted. How about >=2 < 5?

@Andarist
Copy link
Member

I second what @loganfsmyth said, it seems pretty much as * in disguise. Even specifying <5 is a little bit stretch as we do not have certainty that it will work for webpack@4 - it is not released after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants