-
-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resolve-rc): look for babel in package.json #456
Conversation
Awesome thank you very much. |
Now it is not work as expected. Step:
How to solve:
|
@evilebottnawi I think what @danez was saying is for performance sake What you mention is a different issue and from my point of view is not an issue |
@mastilver @danez This is fundamentally wrong and breaks the logic of watching and caching. From webpack channel as say @sokra: sokra [4:54 PM]
configuration files -> loaders should add these files to their dependencies (with `this.addDependency`). dependencies' mtimes are stored by the cache-loader Also it is break loader before, example |
@evilebottnawi I take back what I said but can you open an issue about it, this PR is not related to your issue |
Thanks this was merged with d8b73c0 |
@danez Thank you for taking care of it :) , don't have much time atm |
@danez This hasn't yet been released on npm right? |
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Other information: