Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update babel-plugin-debug-macros to 0.2.0-beta.6 #230

Merged
merged 1 commit into from
Jul 14, 2018

Conversation

kellyselden
Copy link
Member

@rwjblue
Copy link
Member

rwjblue commented Jul 12, 2018

CI passes (which is great!), but emits a bunch of warnings to the console like this:

babel-plugin-debug-macros configuration API has changed, please update your configuration

To fix those warnings we need to tweak this section:

https://github.com/babel/ember-cli-babel/blob/8d8c5919f123073289ed31ac567e4dba8f8abddf/index.js#L246-L260

You can compare the "legacy config" test with this test in babel-plugin-debug-macros for an example.

I think we need something like:

let options = {
  externalizeHelpers: {
    global: "Ember"
  },
  debugTools: {
    isDebug: !isProduction,
    source: "@ember/debug",
    assertPredicateIndex: 1
  },
  flags: [
    {
      source: "@glimmer/env",
      flags: { DEBUG: !isProduction, CI: !!process.env.CI }
    }
  ]
};

@kellyselden kellyselden force-pushed the babel-plugin-debug-macros branch 2 times, most recently from 4991c78 to 48a57ae Compare July 13, 2018 20:57
@kellyselden
Copy link
Member Author

@rwjblue I made the changes you suggested, and now everything looks good.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@kellyselden kellyselden merged commit cb5a382 into emberjs:master Jul 14, 2018
@kellyselden kellyselden deleted the babel-plugin-debug-macros branch July 14, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants