Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle code highlighting for broccoli-middleware >= 2.1.0 #294

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

astronomersiva
Copy link
Contributor

This is needed to unlock ember-cli/broccoli-middleware#51

@astronomersiva
Copy link
Contributor Author

Tried writing tests for this along the lines of

it('returns true when broccoli-middleware version is greater than or equal to 2.1.0', function() {
  this.addon.parent = {
    dependencies() { return { 'broccoli-middleware': '2.1.2' }; }
  };

  expect(this.addon._shouldHighlightCode()).to.be.true;
});

but _shouldHighlightCode() always returns false as the installed version of broccoli-middleware in node_modules is 1.2.1.

@astronomersiva
Copy link
Contributor Author

@stefanpenner please take a look.

@astronomersiva
Copy link
Contributor Author

@stefanpenner please take a look at this as well

@astronomersiva
Copy link
Contributor Author

@stefanpenner a friendly ping :)

@astronomersiva
Copy link
Contributor Author

@stefanpenner @rwjblue can you please take a look at this if you are free?

@stefanpenner
Copy link
Member

@astronomersiva sorry for letting this sit, looks great!

@stefanpenner stefanpenner merged commit 37c3d6c into emberjs:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants