Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept encoding config in InitPrivSigner function instead of creating it. #174

Closed
KonradStaniec opened this issue Oct 24, 2022 · 1 comment
Closed

Accept encoding config in InitPrivSigner function instead of creating it. #174

KonradStaniec opened this issue Oct 24, 2022 · 1 comment
Assignees
@gitferry

Comments

@KonradStaniec
Copy link
Collaborator

Currently InitPrivSigner function - https://github.com/babylonchain/babylon/blob/main/app/utils.go#L62 creates its own encoding config. This should be rather accepted as argument as there should be only one config per app.
@KonradStaniec KonradStaniec mentioned this issue Oct 24, 2022
Merged
@gitferry gitferry self-assigned this Feb 10, 2023
@gitferry gitferry mentioned this issue Feb 17, 2023
Merged
@gitferry
Copy link
Contributor

Resolved by #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitferry gitferry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gitferry @KonradStaniec