Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better way to handle public key #26

Open
jrwbabylonlab opened this issue Sep 13, 2024 · 1 comment
Open

better way to handle public key #26

jrwbabylonlab opened this issue Sep 13, 2024 · 1 comment

Comments

@jrwbabylonlab
Copy link
Collaborator

Investigate a better way to handle the public key VS Public key without coordinates in the FE repos.
Right now, the naming is super confusing or long such as "finalityProviderPkWithNoCoord".

The scope of this ticket is to think about a better approach that can deal with this in a nicer way.
For example,

  • can we have custom type for no coord pk?
  • how about we leave all variable name as public key regardless if it's with or without the coord, then internally, we trim to no coord when needed. OR return as it is when detect it's already trimed to no coord.
  • ...
@jrwbabylonlab
Copy link
Collaborator Author

Conversation tracked here: #23 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant