Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download dependencies for submodules #259

Open
yorkshire-pudding opened this issue Dec 15, 2022 · 2 comments
Open

Download dependencies for submodules #259

yorkshire-pudding opened this issue Dec 15, 2022 · 2 comments
Assignees

Comments

@yorkshire-pudding
Copy link
Collaborator

yorkshire-pudding commented Dec 15, 2022

As a site architect
I want to download dependencies for submodules of the modules I download
So that I'm not blocked from enabling them at the same time

As a bee user
I want the bee download check for existing projects (core and contrib) to check against existing submodules as well as the primary modules
So that I'm not told that bee is going to download a project and then be told it can't find it

This has now been fixed by the fix (#383) to #382 - we now check existing projects by scanning all folders.

Note: At present, while the Backdrop Project Browser will download dependencies for the primary projects downloaded, it doesn't currently download dependencies for submodules.

@ghost
Copy link

ghost commented Mar 25, 2023

Not sure about this... Let's say I have a basic site and want to setup an XML Sitemap. I install https://github.com/backdrop-contrib/xmlsitemap, but since it comes with a sub-module 'xmlsitemap_i18n' then according to my understanding of this issue, it'll also download 'i18n' as a dependency (https://github.com/backdrop-contrib/xmlsitemap/blob/1.x-1.x/xmlsitemap_i18n/xmlsitemap_i18n.info). This would not be desired if all I want is the basic features of XML Sitemap...

So if this is to go forward, I'd highly recommend making it an option for the appropriate command (e.g. --dl-submodule-dependencies), so that those of us who don't want extra modules downloaded don't get them.

@yorkshire-pudding
Copy link
Collaborator Author

Thanks for that feedback @BWPanda - that's a very good point I hadn't thought of. If I do this (it is currently parked) I will definitely make it optional.

@yorkshire-pudding yorkshire-pudding changed the title Download dependencies for submodules and check for existing submodules Download dependencies for submodules Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant