-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax error in file.test prevents File tests from running. #5293
Comments
Ouch, yes, confirmed. It's a regression caused by #3402 As a file related test now fails with fixed syntax, it seems as there might be an additional regression. I'll reopen the other issue, too. |
Thanks @jlfranklin! I missed your PR and filed a second one that did the same thing. 😝 I closed mine and we'll use yours at backdrop/backdrop#3791 In the future when you file your PR, use the word "Fixes" instead of "Addresses" in the description, and GitHub will automatically link them. (I edited your existing PR description to make this change already) |
I confirmed this fixes the tests in file.test and merged backdrop/backdrop#3791 into 1.x and 1.20.x. Thanks @jlfranklin and @indigoxela! |
Description of the bug
There is a syntax error in the
file.test
file that causes errors when running the full test suite. Because the tests never compile, they are not included in the "tests completed" output and don't show as "failed" either.Steps To Reproduce
To reproduce the behavior:
php core/modules/file/tests/file.test
and observe the "PHP Parse error"OR
1.run the test suite with
--group File
Actual behavior
See attached file-test.txt.
file-test.txt
Expected behavior
Tests run as expected.
The text was updated successfully, but these errors were encountered: