Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password support for airplay #754

Closed
chapterjason opened this issue Dec 31, 2020 · 1 comment
Closed

Password support for airplay #754

chapterjason opened this issue Dec 31, 2020 · 1 comment
Labels
feature request next release fixed in develop branch and will be part of the next release

Comments

@chapterjason
Copy link

Is your feature request related to a problem? Please describe.
I'm currently working on a sound system which wraps the snapcast services and set configuration and restart the services.
Adding authentication for airplay is actually not possible, cause the query is not applied if I use this stream: airplay:///shairport-sync?name=Airplay&devicename=Node-Test&password=admin

Describe the solution you'd like
shairport-sync supports setting password via argument .

https://github.com/mikebrady/shairport-sync/blob/272b3db5ffdc7be6d21216c0b602fe02f0cdf3b6/man/shairport-sync.7.xml#L50

Copy the password from the query like the devicename would be a solution.

params_wo_port_ = "\"--name=" + devicename + "\" --output=stdout --use-stderr --get-coverart";

Describe alternatives you've considered
Already thought about change the airplay default configuration, but I think it is easier to add support for the argument.

Additional context

@badaix
Copy link
Owner

badaix commented Dec 31, 2020

Fixed ae16e74

@badaix badaix added the next release fixed in develop branch and will be part of the next release label Dec 31, 2020
@badaix badaix closed this as completed Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request next release fixed in develop branch and will be part of the next release
Projects
None yet
Development

No branches or pull requests

2 participants