Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use "&" as value for parameter in stream URI #850

Closed
uSpike opened this issue Apr 8, 2021 · 4 comments
Closed

Unable to use "&" as value for parameter in stream URI #850

uSpike opened this issue Apr 8, 2021 · 4 comments
Labels
bug next release fixed in develop branch and will be part of the next release

Comments

@uSpike
Copy link
Contributor

uSpike commented Apr 8, 2021

Describe the bug
My wife has a spotify account with many ampersands (&) in the password. At the root of this issue, I'd rather not ask her to change it.

I am unable to configure a stream with parameters like this:

source = spotify://librespot?name=Spotify&username=EMAIL&password=string&with&ampersands&devicename=Snapcast&bitrate=320&killall=false

since I imagine whatever library is parsing this stream doesn't know where the password ends and the devicename starts. I've tried escaping & with %26 but this seems to make no difference.

Steps to Reproduce
Start snapserver with the above config.

@badaix
Copy link
Owner

badaix commented Apr 30, 2021

As a workaround you could run librespot in discovery mode, as discussed here

@uSpike
Copy link
Contributor Author

uSpike commented Apr 30, 2021

@badaix hey thanks for the suggestion, I didn't know that feature existed. It seems to work well for my use case.

@badaix badaix added bug next release fixed in develop branch and will be part of the next release labels May 3, 2021
@badaix
Copy link
Owner

badaix commented May 3, 2021

@uSpike good to hear, the decoding is now fixed with commit a2168f1

@badaix
Copy link
Owner

badaix commented May 15, 2021

Released in Snapcast v0.25.0

@badaix badaix closed this as completed May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug next release fixed in develop branch and will be part of the next release
Projects
None yet
Development

No branches or pull requests

2 participants