Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send better user-agent values #6268

Closed
chris48s opened this issue Mar 12, 2021 · 0 comments · Fixed by #7309
Closed

Send better user-agent values #6268

chris48s opened this issue Mar 12, 2021 · 0 comments · Fixed by #7309
Labels
core Server, BaseService, GitHub auth self-hosting Discussion, problems, features, and documentation related to self-hosting Shields

Comments

@chris48s
Copy link
Member

📋 Description

At the moment we send a hard-coded user-agent header.

It would be nice if:

  • Shields.io itself sent a different value than self-hosted instances send by default (obviously customisation/spoofing is possible)
  • The user agent contained some kind of meaningful indication of the server version

One useful thing we can do is write the version to a file we can read from when we prep a release.
We would probably also want to set a default user agent and then make it configurable via an env var we can set in production.

A bit more discussion on this: #6256 (comment)

@chris48s chris48s added self-hosting Discussion, problems, features, and documentation related to self-hosting Shields core Server, BaseService, GitHub auth labels Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth self-hosting Discussion, problems, features, and documentation related to self-hosting Shields
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant