Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static badge Make Badge button always disabled on Safari #7324

Closed
LitoMore opened this issue Dec 2, 2021 · 9 comments · Fixed by #7449
Closed

Static badge Make Badge button always disabled on Safari #7324

LitoMore opened this issue Dec 2, 2021 · 9 comments · Fixed by #7449
Labels
bug Bugs in badges and the frontend frontend The React app and the infrastructure that supports it good first issue New contributors, join in!

Comments

@LitoMore
Copy link
Contributor

LitoMore commented Dec 2, 2021

Are you experiencing an issue with...

shields.io

🐞 Description

Operating system: macOS Monetary
Browser version: Safari 15.1

How to reproduce

  1. Open Safari
  2. Open https://shields.io
  3. Fill inputs for Make Badge

Relevant issue

I cannot open http://localhost:3000 on my local. It always shows the error view. This issue can only be reproduced on Safari.

CleanShot 2021-12-02 at 13 43 51@2x

I guess it's a gatsby-related issue.

🔗 Link to the badge

No response

💡 Possible Solution

No response

@LitoMore LitoMore added the question Support questions, usage questions, unconfirmed bugs, discussions, ideas label Dec 2, 2021
@paulmelnikow paulmelnikow changed the title Make Badge button always disabled on Safari Static badge Make Badge button always disabled on Safari Dec 2, 2021
@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend frontend The React app and the infrastructure that supports it good first issue New contributors, join in! and removed question Support questions, usage questions, unconfirmed bugs, discussions, ideas labels Dec 2, 2021
@paulmelnikow
Copy link
Member

Confirmed on Safari 14.1.2. Thanks for the report.

Screen Shot 2021-12-02 at 9 12 35 AM

I see that exception in the JavaScript console too though I am not sure if it is related to the button activation.

Pull requests welcome!

@chris48s
Copy link
Member

chris48s commented Dec 4, 2021

This is an issue where it would be great to get a community contribution for the fix, or a bit of time from you @paulmelnikow if nobody steps in. I don't use a mac so can't reproduce/debug this and I'm pretty sure Caleb/P-Y don't use macs either

@calebcartwright
Copy link
Member

Correct, I've no way of testing this. I was curious whether any automated testing (with Cypress or otherwise) would be capable of detecting/confirming/preventing this sort of thing, though I suppose we'd at least need a Mac build/CI environment to test on

@LitoMore
Copy link
Contributor Author

LitoMore commented Dec 4, 2021

OK. I can give a check.

@chris48s
Copy link
Member

chris48s commented Jan 5, 2022

My theory is that this issue is caused by sindresorhus/decamelize#36 after upgrading decamelize in #7098

I've submitted a PR over at #7449 to revert decamelize to version 5. I have no way of testing this myself but is someone who has an i-Device of some description able to check the staging deploy at https://shields-staging-pr-7449.herokuapp.com/ and see if that fixes it in Safari? The staging deploy is on a dyno that goes to sleep so it might take a while to load

@paulmelnikow
Copy link
Member

Unfortunately no dice:

Screen Shot 2022-01-05 at 4 28 10 PM

@LitoMore
Copy link
Contributor Author

LitoMore commented Jan 6, 2022

@chris48s Sindre already mentioned that. Let's stay on version 3.

Both decamelize and humanize-string need to be downgraded.

@chris48s
Copy link
Member

chris48s commented Jan 6, 2022

New staging deploy up. Can we try this one?
https://shields-staging-pr-7449.herokuapp.com/

@LitoMore
Copy link
Contributor Author

LitoMore commented Jan 6, 2022

Tested on my Mac. Works well.

CleanShot 2022-01-07 at 03 36 00@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in badges and the frontend frontend The React app and the infrastructure that supports it good first issue New contributors, join in!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants