Set a higher default cacheLength on rating/star category
#7587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
approved these changes
Feb 10, 2022
For those who were wondering, it's about 1.1% of our served badges according to metrics.shields.io. |
PyvesB
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the things to come out of #7584 is that rating and star badges don't have any explicit
cacheLengthset on them so they just use the default (120 sec). I've never bothered setting one because we serve so few of these in the grand scheme of things. In terms of the way we characterise badges based on how often we expect the values to change and how precise the values need to be, it is probably most sensible to think of these in the same bucket as a download counts.I don't expect this to make much difference to our performance/load because they make up such a small proportion of our traffic, but it will reduce the amount of traffic on upstream APIs a bit.