Add [piwheels] version badge #7656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
the
service-badge
calebcartwright
approved these changes
Mar 1, 2022
Comment on lines
+77
to
+79
| if (includePrereleases) { | ||
| return allReleases[0].version | ||
| } |
There was a problem hiding this comment.
I didn't see anything in the docs indicating a sort order, so figured I'd double check to confirm they are?
There was a problem hiding this comment.
Yeah its a good question. I did look over the source for piwheels. The code that generates the HTML pages and the JSON API does parse all the versions to PEP440 version objects and then sorts them. https://github.com/piwheels/piwheels/blob/fd6f3d12d9a33390ccb235a2995edb24a8fa782d/piwheels/master/the_scribe.py#L525-L542 I'm happy to rely on the ordering, even though it is not explicitly called out in the API docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6506
I don't often do PRs adding a new badge these days, but I'd like this one to exist :)
The transform method is fairly comprehensively unit tested, so I've kept the live tests fairly light-touch.