Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a [pub] publisher badge #7715

Merged
merged 7 commits into from
Mar 19, 2022
Merged

Add a [pub] publisher badge #7715

merged 7 commits into from
Mar 19, 2022

Conversation

devoncarew
Copy link
Contributor

This PR adds a new badge for the pub package publisher information. More details on the proposed badge is available at #7714. Also, there's an existing pub version badge at https://github.com/badges/shields/tree/master/services/pub. Thanks!

@shields-ci
Copy link

shields-ci commented Mar 11, 2022 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @devoncarew!

Generated by 🚫 dangerJS against 2883198

@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label Mar 15, 2022
@shields-cd shields-cd temporarily deployed to shields-staging-pr-7715 March 15, 2022 20:37 Inactive
chris48s
chris48s reviewed Mar 15, 2022
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing. Aside from that, looks good

services/pub/pub-publisher.service.js Outdated Show resolved Hide resolved
@shields-cd shields-cd temporarily deployed to shields-staging-pr-7715 March 15, 2022 22:01 Inactive
@devoncarew
Copy link
Contributor Author

Thanks for the review - updated.

calebcartwright
calebcartwright reviewed Mar 16, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few thoughts from me as well though agree with the general sentiment about this looking good 👍

services/pub/pub-publisher.service.js Outdated Show resolved Hide resolved
services/pub/pub-publisher.service.js Outdated Show resolved Hide resolved
services/pub/pub-publisher.service.js Outdated Show resolved Hide resolved
services/pub/pub-publisher.tester.js Outdated Show resolved Hide resolved
services/pub/pub-publisher.service.js Outdated Show resolved Hide resolved
devoncarew
devoncarew commented Mar 16, 2022
View reviewed changes
Copy link
Contributor Author

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Comments in-line; I'll make code changes and ping this PR again once they're uploaded.

services/pub/pub-publisher.service.js Outdated Show resolved Hide resolved
services/pub/pub-publisher.service.js Outdated Show resolved Hide resolved
services/pub/pub-publisher.tester.js Outdated Show resolved Hide resolved
services/pub/pub-publisher.service.js Outdated Show resolved Hide resolved
services/pub/pub-publisher.service.js Outdated Show resolved Hide resolved
@shields-cd shields-cd temporarily deployed to shields-staging-pr-7715 March 16, 2022 19:45 Inactive
devoncarew
devoncarew commented Mar 16, 2022
View reviewed changes
Copy link
Contributor Author

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR's now updated based on the review comments.

Note that I wasn't able to make one requested change - the feedback around test registration.

Here is the current look of the badges:

Screen Shot 2022-03-16 at 12 43 51 PM

Screen Shot 2022-03-16 at 12 44 38 PM

Screen Shot 2022-03-16 at 12 43 43 PM

services/pub/pub-publisher.service.js Outdated Show resolved Hide resolved
services/pub/pub-publisher.tester.js Outdated Show resolved Hide resolved
@devoncarew @calebcartwright
Apply suggestions from code review
87bfecd 
Co-authored-by: Caleb Cartwright <calebcartwright@users.noreply.github.com>
@shields-cd shields-cd temporarily deployed to shields-staging-pr-7715 March 17, 2022 19:41 Inactive
devoncarew
devoncarew commented Mar 17, 2022
View reviewed changes
Copy link
Contributor Author

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - review suggestions (for the fixes to the test registration) accepted.

@shields-cd shields-cd temporarily deployed to shields-staging-pr-7715 March 17, 2022 19:51 Inactive
@shields-cd shields-cd temporarily deployed to shields-staging-pr-7715 March 18, 2022 22:24 Inactive
calebcartwright
calebcartwright approved these changes Mar 19, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@calebcartwright calebcartwright merged commit 92173a8 into badges:master Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s left review comments

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a 'publisher' badge for Dart packages
5 participants
@devoncarew @shields-ci @chris48s @calebcartwright @shields-cd