Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add [gitlabissues] service #8108

Merged
merged 4 commits into from
Jul 4, 2022
Merged

feat: add [gitlabissues] service #8108

merged 4 commits into from
Jul 4, 2022

Conversation

sunny0826
Copy link
Contributor

re #8077

@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label Jun 20, 2022
@shields-ci
Copy link

shields-ci commented Jun 20, 2022 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @sunny0826!

Generated by 🚫 dangerJS against 89c7729

@calebcartwright
Copy link
Member

Will try to get to this soon. It's a bit on the larger side so will need a bit more time to be carved out for a review 😄

calebcartwright
calebcartwright reviewed Jul 2, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the continued work on the GitLab badges! I've done a pass through most of this and have left inline feedback below for your review

services/gitlab/gitlab-issues.service.js Outdated Show resolved Hide resolved
services/gitlab/gitlab-issues.service.js Outdated Show resolved Hide resolved
services/gitlab/gitlab-issues.service.js Outdated Show resolved Hide resolved
services/gitlab/gitlab-issues.service.js Outdated Show resolved Hide resolved
services/gitlab/gitlab-issues.service.js Outdated Show resolved Hide resolved
services/gitlab/gitlab-issues.service.js Outdated Show resolved Hide resolved
services/gitlab/gitlab-issues.service.js Outdated Show resolved Hide resolved
services/gitlab/gitlab-issues.service.js Outdated Show resolved Hide resolved
services/gitlab/gitlab-issues.service.js Outdated Show resolved Hide resolved
services/gitlab/gitlab-issues.service.js Outdated Show resolved Hide resolved
@sunny0826
Copy link
Contributor Author

@chris48s @calebcartwright
Feedback on Circle CI not running issue: According to this #8109 , Circle CI can be triggered automatically based on push after I finish registration. Perhaps that note could be added to the contributor documentation.

@repo-ranger repo-ranger bot merged commit e9c0851 into badges:master Jul 4, 2022
@sunny0826 sunny0826 deleted the feat/gitlab-issue branch July 4, 2022 23:53
@sunny0826 sunny0826 mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunny0826 @shields-ci @calebcartwright