increase cache length on AUR version badge, run [AUR] #8110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcartwright
added
the
service-badge
calebcartwright
commented
Jun 20, 2022
services/aur/aur.service.js
Outdated
| @@ -108,7 +108,7 @@ class AurVotes extends BaseAurService { | |||
|
|
|||
| class AurVersion extends BaseAurService { | |||
| static category = 'version' | |||
|
|
|||
| static _cacheLength = 3600 | |||
There was a problem hiding this comment.
Open to alternative suggestions, but I'm very intentionally swinging fairly big here. Of the >18k AUR requests we've had over the last 24 hours, nearly 16k of those were for the version badges.
I realize that version badges tend to be more sensitive to recency needs, but I think we'll need to be aggressive here if we're to have a chance of staying within AURs 4k/day limit
chris48s
previously approved these changes
Jun 20, 2022
|
Is circle not working on in-repo PRs now too?? |
|
It is the first time I've seen it happen on one that is not from a fork, but apparently so.. |
|
chris48s
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #7863