Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moar fixes for [gitlab] auth #8162

Merged
merged 6 commits into from
Jul 2, 2022
Merged

moar fixes for [gitlab] auth #8162

merged 6 commits into from
Jul 2, 2022

Conversation

chris48s
Copy link
Member

@chris48s chris48s commented Jul 2, 2022

closes #8143

I feel like one way and another we collectively dropped the ball a bit on code review with these gitlab badges

@chris48s chris48s added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs labels Jul 2, 2022
@shields-ci
Copy link

shields-ci commented Jul 2, 2022 •
edited
Loading

Warnings
⚠️

📚 Remember to ensure any changes to config.private in services/gitlab/gitlab-base.js are reflected in the server secrets documentation
⚠️

📚 Remember to ensure any changes to config.private in services/gitlab/gitlab-contributors.service.js are reflected in the server secrets documentation
Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!

Generated by 🚫 dangerJS against ed4f1d4

calebcartwright
calebcartwright approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof. hate missing things that are all of ~5 lines apart

@repo-ranger repo-ranger bot merged commit 076ee25 into badges:master Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gitlab Badges not working for Private Repositories
3 participants
@chris48s @shields-ci @calebcartwright