-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add [gitlabmergerequests] service #8166
Conversation
|
Have only done a quick pass through this but a couple early notes:
|
@sunny0826 just want to make sure you saw this 👉 #8166 (comment) |
I saw this, but wasn't sure what I needed to do. |
Ah okay, no worries! In the future don't hesitate to ask questions in these types of cases, especially if something is unclear. I'll follow up tomorrow with some elaboration on my prior comment so we can figure out next steps |
After looking through a little more closely, I see that you are already applying special case handling to the >10k scenario which is good 👍 (I was just emphasizing that we should in my prior comment). The second part of my comment was really just related to the length of some of those methods, and a suggestion to consider using the Finally, thanks again for all your work on these GitLab badges, it's very much appreciated! |
Thank you for your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks and apologies for the delay! I think the core of this is in place, just have a few suggestions/requested changes detailed below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you for the updates. Few additional asks but think we're on the home stretch.
These issue/PR/MR types of badges can get quite involved so thanks for sticking with it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates and apologies for the delay in review. Few final items then think we'll be set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed one final thing, noted inline below
re #8077