From ea7d7b85fe26d58a7dd69ac3a57870b038a9e992 Mon Sep 17 00:00:00 2001 From: chris48s Date: Tue, 28 Dec 2021 20:15:07 +0000 Subject: [PATCH 1/2] apply colour scheme to reddit karma badge --- services/reddit/user-karma.service.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/services/reddit/user-karma.service.js b/services/reddit/user-karma.service.js index 76eeb7769b0b2..b53edfc68a393 100644 --- a/services/reddit/user-karma.service.js +++ b/services/reddit/user-karma.service.js @@ -25,7 +25,7 @@ export default class RedditUserKarma extends BaseJsonService { staticPreview: { label: 'combined karma', message: 56, - color: 'red', + color: 'brightgreen', style: 'social', }, }, @@ -44,7 +44,7 @@ export default class RedditUserKarma extends BaseJsonService { return { label, message: metric(karma), - color: 'red', + color: karma > 0 ? 'brightgreen' : karma === 0 ? 'orange' : 'red', link: [`https://www.reddit.com/u/${user}`], } } From 7db86f22c528f41f800732eb2c761cb0afeaa9e8 Mon Sep 17 00:00:00 2001 From: chris48s Date: Tue, 28 Dec 2021 20:15:36 +0000 Subject: [PATCH 2/2] accept negative metric in reddit karma tests --- services/reddit/user-karma.tester.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/services/reddit/user-karma.tester.js b/services/reddit/user-karma.tester.js index 9023023dbb630..a7eb8d83c0002 100644 --- a/services/reddit/user-karma.tester.js +++ b/services/reddit/user-karma.tester.js @@ -1,4 +1,4 @@ -import { isMetric } from '../test-validators.js' +import { isMetricAllowNegative } from '../test-validators.js' import { createServiceTester } from '../tester.js' export const t = await createServiceTester() @@ -6,21 +6,21 @@ t.create('user-karma (valid - link)') .get('/link/user_simulator.json') .expectBadge({ label: 'u/user_simulator karma (link)', - message: isMetric, + message: isMetricAllowNegative, }) t.create('user-karma (valid - comment') .get('/comment/user_simulator.json') .expectBadge({ label: 'u/user_simulator karma (comment)', - message: isMetric, + message: isMetricAllowNegative, }) t.create('user-karma (valid - combined)') .get('/combined/user_simulator.json') .expectBadge({ label: 'u/user_simulator karma', - message: isMetric, + message: isMetricAllowNegative, }) t.create('user-karma (non-existing user)')