Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the fetch URL for Github Actions workflow status badge #8310

Closed
wants to merge 1 commit into from
Closed

Correct the fetch URL for Github Actions workflow status badge #8310

wants to merge 1 commit into from

Conversation

exoRift
Copy link

@exoRift exoRift commented Aug 12, 2022

Fixes: #8309

The Github Actions workflow status badge fetches the wrong URL for the native badge SVG.

This PR prepends /actions/ to /workflows/ in the URL.

@shields-ci
Copy link

Warnings
⚠️ This PR modified service code for github but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @exoRift!

Generated by 🚫 dangerJS against 52ce4db

@exoRift exoRift changed the title Correct the fetch URL for Github Actions workflow status Correct the fetch URL for Github Actions workflow status badge Aug 12, 2022
@calebcartwright calebcartwright added the on-hold Deferred in favor of another approach, blocked on preceding efforts, stale, or abandoned label Aug 13, 2022
@chris48s
Copy link
Member

We merged #8475 instead. See #8671 for details

@chris48s chris48s closed this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on-hold Deferred in favor of another approach, blocked on preceding efforts, stale, or abandoned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Action status badge can't find my workflow
4 participants
@exoRift @shields-ci @chris48s @calebcartwright