Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if dependent module actually depends on this module first #11

Open
bahmutov opened this issue Nov 6, 2014 · 2 comments
Open

Check if dependent module actually depends on this module first #11

bahmutov opened this issue Nov 6, 2014 · 2 comments
Labels

Comments

@bahmutov
Copy link
Owner

bahmutov commented Nov 6, 2014

Otherwise the copy / tests can fail and give invalid answer

@bahmutov bahmutov added the minor label Nov 6, 2014
@mtscout6
Copy link

When doing this you may want to consider checking dependencies, devDependencies and peerDependencies. I say this as some tools are meant to be dev dependencies such as mocha, eslint, or babel.

@cristiingineru
Copy link
Contributor

Let's say we have a 3 level deep hierarchy like this:

module C -> module B -> module A

If we want dont-break to run all the tests from all the upstream dependents of module A then the .dont-break.json looks like this:

[
  "https://github.com/user/moduleB",
  "https://github.com/user/moduleC"
]

At this point, based on the above configuration file, dont-break is syncing and running the tests from the modul B as expected, but then it fails after syncing module C because it checks to see whether C is directly depending on A which is not the case.

I think this direct dependency check is not needed and it should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants