Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when installing packages #39

Closed
pete-redmond-cko opened this issue Aug 12, 2020 · 7 comments · Fixed by #40
Closed

Error when installing packages #39

pete-redmond-cko opened this issue Aug 12, 2020 · 7 comments · Fixed by #40
Labels

Comments

@pete-redmond-cko
Copy link

Hey 👋

Our checks started failing about 2 days ago with a reserveCache failed error (see below). The error is very sporadic and will usually fix itself when we run the checks again.

reserveCache failed: Cache already exists. Scope: refs/heads/dependabot/npm_and_yarn/testing-library/jest-dom-5.11.3, Key: yarn-linux-x64-a81ae0ca03461d6790722af5d4c65aa4f4cd99693156b291b879b1fdacf3941f460c2fba5f9aafc8b9a8dbbbeb6d5ca9a551489d773bd02d23a8ae52ce6497ea, Version: db8d7573c9c1e018880f416d1266a74a2aca6c42332d4f92d877cf07990531be

I noticed a new release was made 2 days ago. Do you think the new release is causing the issue?

@tom-finlayson-cko
Copy link

We're also experiencing the same issue on some of our workflow runs. Have pinned to the previous version of v1.4.1 this morning and that seems to have resolved the issue/got our workflow running successfully again

@mforman1
Copy link

@tom-finlayson-cko May I ask how do you downgrade the npm-install version?

@tom-finlayson-cko
Copy link

@mforman1 Sure thing, just had to set the version explicity for the step like so
uses: bahmutov/npm-install@v1.4.1

@agilgur5
Copy link
Contributor

agilgur5 commented Aug 14, 2020

Yep, sorry folks that's totally my bad, my PR #37 passed the CI checks (self-integration tests) I added, but then those same checks somehow failed immediately after merge to master and subsequent pushes there. I'm guessing bahmutov didn't see those failures before he published the change:

This update also apparently changed a previous warning on a race condition to an error now (as can be seen in the failed checks in recent runs here, in TSDX, and in salsita/react-training#60 that mentioned this PR... not sure how the checks passed on my fork 🤔 ), so I've gotta add a hotfix PR to fix that as well ASAP

If you have a race condition in your workflow, e.g. a matrix install on different Node versions, but same OS, the first job to finish will save cache properly and the rest will error when saving. According to salsita/react-training#60 's investigation, this was previously a warning in unofficial @actions/cache fork, but in the official version I upgraded to, it is now an error.

Going to try getting a hotfix out for that ASAP, should just be adding a try/catch, but in the meantime, feel free to downgrade to v1.4.1 as @tom-finlayson-cko laid out.

@agilgur5
Copy link
Contributor

This also seems to be a long-standing upstream error as well: actions/cache#144 . It was a warning previously though, now it's an error

@tom-finlayson-cko
Copy link

Thanks for explaining @agilgur5, makes sense now why we we've only been seeing the error in our matrix workflows

@github-actions
Copy link

🎉 This issue has been resolved in version 1.4.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants