Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong indexing in infinite scroll mode #120

Closed
vedmaque opened this issue Aug 8, 2019 · 1 comment · Fixed by #124
Closed

Wrong indexing in infinite scroll mode #120

vedmaque opened this issue Aug 8, 2019 · 1 comment · Fixed by #124
Labels
bug Something isn't working

Comments

@vedmaque
Copy link

vedmaque commented Aug 8, 2019

Describe the bug
I've updgaded to 0.3.x version and infinite scroll mode seems to be broken.

To Reproduce
Steps to reproduce the behavior:

  1. Set infiniteScroll to true
  2. See the generated html. Some of slides will have is-current class, most of them will have is-prev class. Indexes of 3 slides looks like this [0, 1, 2, 0, 1, 2, -3, -2, -1] (see screenshot)

Expected behavior
Expect prev slides to have is-prev class, next slides to have is-next slides.
Expect indexes like this [-3, -2, -1, 0, 1, 2, 3, 4, 5] for the 3 slides count

Screenshots
https://jmp.sh/1elHRxg

Desktop:

  • OS: macOS 10.14.5
  • Browser: Chrome
  • Version: 75.0
@logaretm
Copy link
Contributor

Thanks for reporting this, I found the issue and fixed it. This will be available shortly in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants