Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generic typing to Arrowbic base extension type #17

Open
balancap opened this issue Jan 18, 2022 · 1 comment
Open

Add generic typing to Arrowbic base extension type #17

balancap opened this issue Jan 18, 2022 · 1 comment
Assignees
@balancap
Labels
bug Something isn't working enhancement New feature or request

Comments

@balancap
Copy link
Owner

balancap commented Jan 18, 2022 •
edited
Loading

Adding generic typing is improving the general code quality, as well as, making usability of the library better in common IDEs (VS code, ...)
@balancap balancap added the enhancement New feature or request label Jan 18, 2022
@balancap balancap self-assigned this Jan 18, 2022
@balancap balancap linked a pull request Jan 18, 2022 that will close this issue
Add generic typing to Arrowbic extension type class. #19
Closed
@balancap balancap added the bug Something isn't working label Jan 19, 2022
@balancap balancap changed the title Add generic typing to Arrowbic base extension type and array Add generic typing to Arrowbic base extension type Jan 19, 2022
@balancap
Copy link
Owner Author

balancap commented Jan 19, 2022 •
edited
Loading

Currently blocked by issue in PyArrow implementation: it does not support generic extension type, i.e.

TItem = TypeVar("TItem")

class BaseExtensionType(pa.ExtensionType, Generic[TItem]):
    pass

will lead a failure when calling pa.ExtensionArray.from_storage factory method.

Implementing the generic feature only for ExtensionArray at the moment, in #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balancap balancap

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add generic typing to Arrowbic extension type class. balancap/arrowbic
1 participant
@balancap