Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not upgrade express from version 3.x to 4.x? #2938

Closed
huguangju opened this issue May 16, 2015 · 11 comments
Closed

Why not upgrade express from version 3.x to 4.x? #2938

huguangju opened this issue May 16, 2015 · 11 comments
Labels

Comments

@huguangju
Copy link

Migrating from 3.x to 4.x

@tjwebb
Copy link
Contributor

tjwebb commented May 17, 2015

This is something we'd love to do in the next release. If you'd like to help, a PR would be appreciated.

cc @loicsaintroch

@listepo
Copy link
Contributor

listepo commented May 19, 2015

I think it would be logical to make these changes after #2833 to see how the changed code coverage.

@listepo
Copy link
Contributor

listepo commented Jun 7, 2015

I started to work. I would be grateful for the help. https://github.com/listepo/sails/tree/next

@nikhiljohn10
Copy link

Currently A default sails app is eating 140 - 160 MB of my server RAM and it increase as the app is modified. I create a Express 4.0 App. It used only 20 - 70 MB. Can anyone explain why the RAM usage is high is Sails?

@tjwebb
Copy link
Contributor

tjwebb commented Jun 8, 2015

"eating 140MB of RAM" is not a bug. There are tons of other memory usage threads in github that you can search. Please read through those before you file memory usage issues.

@nikhiljohn10
Copy link

Ok.

@sailsbot
Copy link

Thanks for posting, @huguangju. I'm a repo bot-- nice to meet you!

It has been 60 days since there have been any updates or new comments on this page. If this issue has been resolved, feel free to disregard the rest of this message. On the other hand, if you are still waiting on a patch, please:

  • review our contribution guide to make sure this submission meets our criteria (only verified bugs with documented features, please; no questions, commentary, or bug reports about undocumented features or unofficial plugins)
  • create a new issue with the latest information, including updated version details with error messages, failing tests, and a link back to the original issue. This allows GitHub to automatically create a back-reference for future visitors arriving from search engines.

Thanks so much for your help!

@mikermcneil
Copy link
Member

Currently A default sails app is eating 140 - 160 MB of my server RAM and it increase as the app is modified. I create a Express 4.0 App. It used only 20 - 70 MB. Can anyone explain why the RAM usage is high is Sails?

@nikhiljohn10 The rest of the core team and I spent a lot of time analyzing this and other memory concerns earlier this year when we were first scaling the production deployment of Treeline. What we learned is that the 140-160MB RAM usage in development is probably due to the Grunt child process running in the background, along with the fact that Sails has more dependencies than Express. We've never experienced any sort of problems due to this alone (although there have been memory leak issues stemming from the release of Node v0.12, but those have since been resolved in a patch release to Node core-- be sure and check your versions though).

Hope that helps!

@mikermcneil
Copy link
Member

@huguangju re: upgrading Express, see #3235 (comment) for our plans.

@mikermcneil
Copy link
Member

(locking this issue to funnel future discussion into the linked PR so it's easier to track)

@balderdashy balderdashy locked and limited conversation to collaborators Jan 12, 2016
@mikermcneil
Copy link
Member

For future reference, there's more information and tips on diagnosing memory leaks in Node apps, and on reproducing+reporting suspected memory leaks in Sails here:
#3782 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

6 participants