Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple sort support on blueprints #2450

Closed
wants to merge 2 commits into from

Conversation

Dallas62
Copy link
Contributor

Hi!

This PR add multiple sort support on blueprints

Basic usage still working: ?sort=foo ASC
but add JSON support like ?sort={foo: 'ASC', bar: 'DESC'} (basically same parameters than Waterline)

As referred #2449

Tacyniak added 2 commits November 27, 2014 18:54
Hi!

This PR add multiple sort support on blueprints

Basic usage of `?sort=foo ASC` still working
and add JSON support like `?sort={foo: 'ASC', bar: 'DESC'}` (basically same parameter than Waterline)

As refered balderdashy#2449
@Dallas62
Copy link
Contributor Author

Look at commits, you will see a travis timeout on pubsub

@kevinburkeshyp
Copy link

Should prolly add a test for this

@tjwebb
Copy link
Contributor

tjwebb commented Mar 28, 2015

@Dallas62 can you include a test that shows how this works? thanks

@Dallas62
Copy link
Contributor Author

@tjwebb We are leaving Sails from our projects, I don't have enough time for that.
Data for integration tests doesn't help to quickly include test. There is only properties with the userId so I can not use them for more than one sorting arguments.

I tested it with waterline-adapter-tests and a custom Waterline adapter based on Blueprint and I will probably publish it soon.

Cordially.

@tjwebb tjwebb closed this Mar 28, 2015
Dallas62 pushed a commit to Dallas62/Sails-Rest that referenced this pull request May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants