fix(core): 🐛 update title with "next"

Closes #384
barbajs · Apr 23, 2019 · f8c1940 · f8c1940
1 parent a06ec61
commit f8c1940
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 12 deletions.
diff --git a/packages/core/src/core.ts b/packages/core/src/core.ts
@@ -392,7 +392,6 @@ export class Core {
         wrapper: this._wrapper,
       });
 
-      this._updateTitle(data);
       this._resetData();
     } catch (error) {
       // Something went wrong (rejected promise, error, 404, 505, other…)
@@ -585,16 +584,6 @@ export class Core {
 
     this.hooks.do('reset', this.data);
   }
-
-  /**
-   * Update document title.
-   */
-  private _updateTitle(data: ITransitionData): void {
-    const { html } = data.next;
-    const { title } = this.dom.toDocument(html);
-
-    document.title = title;
-  }
 }
 
 const core = new Core();

diff --git a/packages/core/src/utils/dom.ts b/packages/core/src/utils/dom.ts
@@ -13,7 +13,7 @@
 /***/
 
 // Definitions
-import { ISchemaAttribute, Scope, Wrapper } from '../defs';
+import { ISchemaAttribute, ITransitionData, Scope, Wrapper } from '../defs';
 // Schemas
 import { schemaAttribute } from '../schemas/attribute';
 

diff --git a/packages/core/src/utils/helpers.ts b/packages/core/src/utils/helpers.ts
@@ -39,6 +39,10 @@ export const updateNext = async (
       // next.html = dom.getHtml(nextDocument);
       // next.html = nextDocument.innerHTML;
       next.html = html;
+
+      const { title } = dom.toDocument(html);
+
+      document.title = title;
     }
   }
 };