-
-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility : harmful live-region usage #681
Comments
Hi @blokche, Sorry but we are not managing any Barba JS is here to give you page transition power, we are aware of SEO concerns but the library doesn't manage any additional SEO stuff / attributes, you need to do it yourself. Thanks for highlighting. |
Hi. Thanks for your answer. Forgive my insistence but what about this line (186) in |
Hi @blokche, I am not an expert in WAI. May be @thierrymichel can add further / additional informations to my post.
|
Setting aria-live on the wrapper should be avoided since it will read out the entire page on every visit. The ideal solution would be to announce page visits with a live region (e.g. barba.hooks.ready(() => {
const wrapper = barba.dom.getWrapper()
wrapper.removeAttribute('aria-live')
}) |
+1 for everything @daun added. @xavierfoucrier I believe you may have misunderstood @blokche's original note. @blokche, please correct me if I'm wrong, but I don't believe you were asking for Barba to do more, but instead hoping for Barba to actually do less. Currently, Barba automatically applies a @daun's suggestion is a good one. It's a simple way to remove the I understand that A11Y stuff can be really challenging and issues don't always have a single, obvious solution. But I think this issue is worth reopening and reconsidering. |
@blokche @daun @brettburwell Hi guys! Small update, I am now considering this as a bug fix, since it's not a good implementation with most assistive technologies. Thanks everyone for your useful comments 😉 |
Hi @xavierfoucrier. That's great news! Thanks for taking a second look at this issue and reconsidering. |
I was considering using barba.js for projects but I'm a bit disapointed with the usage of the aria-live region set on the wrapper element. It was a good intention but to me it's more harmful than helpful as it is implemented.
SPA navigation are often a bit challenging for assistive technologies users but some patterns have been tested with real users. Live regions can be useful but you don't want the whole document to be read aloud by assistive technologies. Only a page title should be announed in those elements.
The focus may be moved too, but I guess it's more the responsability of the developer to listen for page transition event and do the right choice for its use case. The documentation may help to build appropriate patterns, without forcing an opiniated behavior.
The text was updated successfully, but these errors were encountered: