Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update S if S > N/2 instead return false #29

Open
imduchuyyy opened this issue Jun 25, 2024 · 0 comments · May be fixed by #30
Open

Update S if S > N/2 instead return false #29

imduchuyyy opened this issue Jun 25, 2024 · 0 comments · May be fixed by #30

Comments

@imduchuyyy
Copy link

if (webAuthnAuth.s > _P256_N_DIV_2) {

When verify webauth signature. In case S value > _P256_N_DIV_2, library will return false. But we can Canonical S- value to preventing the creation of a second valid signature

        if (webAuthnAuth.s > _P256_N_DIV_2) {
            // guard against signature malleability
            webAuthnAuth.s = FCL_Elliptic_ZZ.n - webAuthnAuth.s;
            //return false;
        }
@imduchuyyy imduchuyyy linked a pull request Jun 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant