Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misrepresentation of editor landscape #1092

Closed
johanneswilm opened this issue Sep 27, 2023 · 2 comments · Fixed by #1093
Closed

Misrepresentation of editor landscape #1092

johanneswilm opened this issue Sep 27, 2023 · 2 comments · Fixed by #1093

Comments

@johanneswilm
Copy link

Hey,
thanks for this great editor. One note though: In your readme, it says:

Most WYSIWYG editors are wrappers around HTML’s contenteditable and execCommand APIs [...]

As the person who has been responsible for the execCommand spec over the past decade (recently stopped), I feel this is a misrepresentation of the editor landscape. Editors generally stopped using execCommand 8-15 years ago. Most production ready editors now do the exact same thing you describe below and they have been doing so for a long time. There seems to be some differences in how much they rely on the beforeinput event, but those are minor details. This may have been true-ish in 2015, but it does not seem to be the case anymore.

Why does it matter?

It has been hard for us to get the message out there that editors should not be built on top of execCommand. The production level editors all know that, but time and again there are individuals who start yet another execCommand-based editor. The waste a year or two of their lives on it, only to realize that it is not technically possible to create a consistent editor that way. Statements like the one in your readme unfortunately do not help as they give an incorrect picture of the editing landscape and give false hope to those trying to create editors that way.

@afcapel
Copy link
Contributor

afcapel commented Sep 28, 2023

@johanneswilm thanks for your work on the execCommand spec as well. I remember reading the spec some time ago and thinking it was impressive that someone had reverse engineered and documented all those browser quirks.

I'm afraid the README was written long time ago and it's a bit outdated. Do the changes in #1093 look good to you?

@johanneswilm
Copy link
Author

@afcapel Yes, thank you. That addresses the issue fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants