Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safari paste bugfix breaks MS Edge (DataTransfer.types is not Array) #452

Closed
metamatt opened this issue Oct 4, 2017 · 3 comments
Closed

Comments

@metamatt
Copy link

metamatt commented Oct 4, 2017

When pasting into trix running in MS Edge (14 or 15), we get: TypeError: Object doesn't support property or method 'some'

This seems to be because code introduced in 95db10b (release 0.10.2) assumes paste.types is an Array like MDN says, whereas Edge says it's "a list of strings" like MSDN says -- note Microsoft's careful avoidance of the use of the word Array.

This is probably an Edge specs-compliance bug, but can Trix avoid using .some on paste.types? It's unfortunate that working around one browser bug (in Safari) exposes another one (in Edge).

Note also that Edge does support Array.prototype.some; the problem here is the object is not in fact a real Array.

Steps to Reproduce
  1. Use MS Edge
  2. Launch a page using Trix newer than 0.10.2
  3. paste
Details
  • Trix version: 0.10.2
  • Browser name and version: Edge 14 or 15
  • Operating system: Windows 10
@javan javan closed this as completed in c2f9f14 Oct 5, 2017
@javan
Copy link
Contributor

javan commented Oct 5, 2017

Thank you for the great report!

@metamatt
Copy link
Author

metamatt commented Oct 5, 2017

👍 thank you!

@tjFreerey
Copy link

I'm noticing the same thing happens when you try loading a .some() method into Internet Explorer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants