Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupted Object and AAE #1824

Closed
martinsumner opened this issue Apr 19, 2022 · 3 comments
Closed

Corrupted Object and AAE #1824

martinsumner opened this issue Apr 19, 2022 · 3 comments
Assignees
Labels

Comments

@martinsumner
Copy link
Contributor

If an object is corrupted in a store - the AAE folds will keep crashing and the AAE trees will never be rebuilt.

It isn't possible to identify which object the fold crashes on, and there is no automated way of doing anything about the crash.

@s2hc-johan

@martinsumner
Copy link
Contributor Author

@s2hc-johan can you have a look at this please?

f54ffa3

Does this look like it should solve the problem?

@martinsumner
Copy link
Contributor Author

martinsumner commented Dec 15, 2022

If a rebuild fold is interrupted by a riak stop ... then as the node shuts down a number of key reads will falsely report corruption, as the FoldObjectsFun will throw {error, badarg} when trying to get_index_n.

We may get an {error, badarg} due to corruption ... so shouldn't just not log. Either need to detect that riak is stopping, or add a disclaimer to ignore if shutting down. The log may otherwise cause unnecessary concern for operators.

@martinsumner martinsumner reopened this Dec 15, 2022
@martinsumner
Copy link
Contributor Author

#1840

On reflection, simply making the log clearer about context should be sufficient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant