Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directive "follow" does not follow symlinks outside of repository #1574

Open
felberj opened this issue Jul 7, 2023 · 0 comments · May be fixed by #1575
Open

Directive "follow" does not follow symlinks outside of repository #1574

felberj opened this issue Jul 7, 2023 · 0 comments · May be fixed by #1575

Comments

@felberj
Copy link

felberj commented Jul 7, 2023

What version of gazelle are you using?


commit b8e12463a6185c2303e4ac2a83f9b20ec76e099c (HEAD, origin/master, origin/HEAD)
Author: Gregor Best <gbe@unobtanium.de>
Date:   Wed Jul 5 18:11:56 2023 +0200

    Fix directive table in Readme file (#1571)

What version of rules_go are you using?

n/a

What version of Bazel are you using?

% bazel version
bazel version
Starting local Bazel server and connecting to it...
Build label: 6.2.0-homebrew
Build target: bazel-out/darwin_arm64-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Jan 1 00:00:00 1980 (315532800)
Build timestamp: 315532800
Build timestamp as int: 315532800

Does this issue reproduce with the latest releases of all the above?

yes

What operating system and processor architecture are you using?

macOS ARM64

What did you do?

# BUILD
# gazelle:follow external

external is a symlink:

% ls -alh external
ls -alh external
lrwxr-xr-x  1 me  staff    27B Apr 19 19:45 external -> bazel-out/../../../external

Running gazelle with

update --mode=diff

What did you expect to see?

It shows diff in external (actually, I just want gazelle to "read" build files in external, but this is what I got)

What did you see instead?

No diff under external

I assume this is a side effect of #1384. I would like to add a feature that if I explicitly add the link to "follow", it should follow it.

@felberj felberj linked a pull request Jul 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant