Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing debug_mode via go_deps to go_repository is not supported #1805

Closed
davidbyttow opened this issue May 18, 2024 · 2 comments · Fixed by #1806
Closed

Passing debug_mode via go_deps to go_repository is not supported #1805

davidbyttow opened this issue May 18, 2024 · 2 comments · Fixed by #1806

Comments

@davidbyttow
Copy link
Contributor

It appears that there is no way to pass in debug_mode to go_repository via go_deps with bzlmod. Unless I'm missing something, this makes it difficult to see when things go wrong during BUILD file generation because errors are not reported directly from the gazelle command.

https://github.com/bazelbuild/bazel-gazelle/blob/f93e45f142de1a32389f1b8798880e5cf903c432/internal/go_repository.bzl#L372-L374

@fmeum
Copy link
Member

fmeum commented May 18, 2024

Happy to review a PR that adds a corresponding attr to the go_deps extension. I could see a single attribute that sets debug_mode for all repo rules being more ergonomic, but it could also turn out too noisy.

@davidbyttow davidbyttow changed the title Passing debug_mode via go_deps to go_repository Passing debug_mode via go_deps to go_repository is not supported May 19, 2024
@davidbyttow
Copy link
Contributor Author

Thanks @fmeum. I added a single attribute to config. LMK if you'd like it elsewhere. Seems like it could be extended per module to be less noisy later. #1806

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants