From 1abe5c871d28637b1982f9db269c9f124905dc23 Mon Sep 17 00:00:00 2001 From: Randolf J <34705014+jrandolf@users.noreply.github.com> Date: Thu, 12 Sep 2024 19:25:06 -0700 Subject: [PATCH] feat: add option to include runfiles during run_binary --- lib/private/run_binary.bzl | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/private/run_binary.bzl b/lib/private/run_binary.bzl index 41e611f18..c18da9e93 100644 --- a/lib/private/run_binary.bzl +++ b/lib/private/run_binary.bzl @@ -58,6 +58,8 @@ Possible fixes: inputs = ctx.files.srcs + [stamp.volatile_status_file, stamp.stable_status_file] envs["BAZEL_STABLE_STATUS_FILE"] = stamp.stable_status_file.path envs["BAZEL_VOLATILE_STATUS_FILE"] = stamp.volatile_status_file.path + elif ctx.attr.include_runfiles: + inputs = ctx.files.srcs + depset(transitive = [src[DefaultInfo].files for src in ctx.attr.srcs]).to_list() else: inputs = ctx.files.srcs @@ -90,6 +92,7 @@ _run_binary = rule( "srcs": attr.label_list( allow_files = True, ), + "include_runfiles": attr.bool(), "out_dirs": attr.string_list(), "outs": attr.output_list(), "args": attr.string_list(), @@ -109,6 +112,7 @@ def run_binary( outs = [], out_dirs = [], mnemonic = "RunBinary", + include_runfiles = False, progress_message = None, execution_requirements = None, use_default_shell_env = False, @@ -177,6 +181,11 @@ def run_binary( See https://docs.bazel.build/versions/main/be/common-definitions.html#common.tags for useful keys. + include_runfiles: Whether to include runfiles in the action's inputs. + + If True, the runfiles of all sources are included in the action's inputs. This is useful + for bundlers that need to access the runfiles of their dependencies. + use_default_shell_env: Passed to the underlying ctx.actions.run. May introduce non-determinism when True; use with care! @@ -217,6 +226,7 @@ def run_binary( outs = outs, out_dirs = out_dirs, mnemonic = mnemonic, + include_runfiles = include_runfiles, progress_message = progress_message, execution_requirements = execution_requirements, use_default_shell_env = use_default_shell_env,