You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's configured to currently just look for python_interpreter = "python3", and now I'm not sure this would work when the underlying interpreter version changes, for example by going from 3.6 to 3.7.
Looking at the resolved typed_ast depending inside my Bazel WORKSPACE's outputBase I see:
Which is clearly 3.6 versioned. If the python3 interpreter is upgraded to 3.7 what happens? I think the repository_rule that downloaded the dependencies wouldn't invalidate (because python_interpreter = or anything else hasn't changed), and the dependencies would be out-of-date.
Bazel docs for repository_rules mention the configure attr which indicates that a repository_rule "inspects the system for configuration purpose". Should this be set on the repository_rule that does deps downloading?
My current idea is that the python_interpreter attr of pip_import should be configurable for the user so that they can specify themselves which interpreter is being used, and have it match how they install dependencies for their WORKSPACE internal code.
The text was updated successfully, but these errors were encountered:
You can now pass through an interpreter like python3.7 which means you specify the minor version. But there's still a problem of what happens if your Python toolchains changes independently of this version (conflict) or if the minor version is upgraded and 3.7 is not longer available (failure). Neither scenario is ideal.
Currently the MyPy
py_binary
this integration ships gets its dependencies usingrules_python
'spip_import
: https://github.com/thundergolfer/bazel-mypy-integration/blob/master/repositories/py_repositories.bzl#L22It's configured to currently just look for
python_interpreter = "python3"
, and now I'm not sure this would work when the underlying interpreter version changes, for example by going from3.6
to3.7
.Looking at the resolved
typed_ast
depending inside my Bazel WORKSPACE's outputBase I see:Which is clearly 3.6 versioned. If the
python3
interpreter is upgraded to 3.7 what happens? I think the repository_rule that downloaded the dependencies wouldn't invalidate (becausepython_interpreter =
or anything else hasn't changed), and the dependencies would be out-of-date.Bazel docs for repository_rules mention the
configure
attr which indicates that a repository_rule "inspects the system for configuration purpose". Should this be set on the repository_rule that does deps downloading?My current idea is that the
python_interpreter
attr ofpip_import
should be configurable for the user so that they can specify themselves which interpreter is being used, and have it match how they install dependencies for their WORKSPACE internal code.The text was updated successfully, but these errors were encountered: