Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a custom mypy executable #34

Closed
person142 opened this issue Jan 9, 2021 · 2 comments
Closed

Allow passing a custom mypy executable #34

person142 opened this issue Jan 9, 2021 · 2 comments

Comments

@person142
Copy link

This is one approach to #19.

We have a custom py_binary wrapping mypy that bundles some plugins. Is the project open to allowing users to pass their own mypy? The simple way would be making _mypy_cli public:

https://github.com/thundergolfer/bazel-mypy-integration/blob/master/mypy.bzl#L23

The more proper way would probably be making a mypy toolchain.

Willing to PR this if it's acceptable.

@thundergolfer
Copy link
Collaborator

I thinking being able to pass the MyPy binary is entirely reasonable. #30 seems like something worth looking at too.

@adzenith
Copy link
Collaborator

This feature just landed in #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants