Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bazelisk version configurable #184

Open
katre opened this issue Aug 25, 2023 · 1 comment
Open

Make bazelisk version configurable #184

katre opened this issue Aug 25, 2023 · 1 comment
Labels
chore Code cleanup or refactor

Comments

@katre
Copy link
Collaborator

katre commented Aug 25, 2023

As part of #181, Bazelisk will be used to download the Bazel used for tests.

With the legacy WORKSPACE support, the Bazelisk version can be configured in the bazel_binaries call:

bazel_binaries(
    bazelisk_version = "1.17.0",
    versions = [
        "//:.bazelversion",
    ],
)

This is not currently possible with the bzlmod support, and should be added.

Possible syntax (this does not work currently):

bazel_binaries = use_extension(
    "@rules_bazel_integration_test//:extensions.bzl",
    "bazel_binaries",
    dev_dependency = True,
)
bazel_binaries.download(version_file = "//:.bazelversion")
bazel_binaries.use_bazelisk("1.17.0")
use_repo(bazel_binaries, "bazel_binaries")
@katre
Copy link
Collaborator Author

katre commented Sep 8, 2023

It would also be handy to have a way to use a local (non-hermetic) bazelisk, to help uncommon os/arch setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Code cleanup or refactor
Projects
None yet
Development

No branches or pull requests

2 participants