Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandboxing breaks ts_proto_library dependencies #2634

Closed
sgammon opened this issue Apr 27, 2021 · 2 comments
Closed

Sandboxing breaks ts_proto_library dependencies #2634

sgammon opened this issue Apr 27, 2021 · 2 comments
Labels
Can Close? We will close this in 30 days if there is no further activity

Comments

@sgammon
Copy link
Contributor

sgammon commented Apr 27, 2021

🐞 bug report

Affected Rule

ts_proto_library / ts_library

Is this a regression?

I don't know. We switched on sandboxing around 2.2.2, so it may have been broken since then.

Description

We have a structure like so:

proto_library(
  name = "some_proto",
  srcs = ["SomeProto.proto"],
  deps = [
    "@proto_common//:type_date",
    "@com_google_protobuf//:struct_proto",
  ],
)

ts_proto_library(
  name = "some_proto_ts",
  proto = ":some_proto",
)

With --spawn_strategy=sandboxed, the code breaks because Rollup cannot locate transitive dependencies of some_proto_ts (i.e. @proto_common//..., etc), but with --spawn_strategy=local the build works fine.

🔬 Minimal Reproduction

I am working on a small repo to isolate this issue which I will link here.

🔥 Exception or Error

Will enclose with repo, but it just fails to find any transitive dependencies of your leaf proto.

🌍 Your Environment

Operating System:

  
macOS Big Sur
Version 11.2.3
  

Output of bazel version:

  
Bazelisk version: v1.8.0
Build label: 4.0.0
Build target: bazel-out/darwin-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Jan 21 07:38:50 2021 (1611214730)
Build timestamp: 1611214730
Build timestamp as int: 1611214730
  

Rules_nodejs version:

(Please check that you have matching versions between WORKSPACE file and @bazel/* npm packages.)

  
3.4.1 (SHA a160d9ac88f2aebda2aa995de3fa3171300c076f06ad1d7c2e1385728b8442fa)
  

Anything else relevant?

Love you guys!

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for 90 days. It will be closed if no further activity occurs in two weeks. Collaborators can add a "cleanup" or "need: discussion" label to keep it open indefinitely. Thanks for your contributions to rules_nodejs!

@github-actions github-actions bot added the Can Close? We will close this in 30 days if there is no further activity label Jul 27, 2021
@github-actions
Copy link

This issue was automatically closed because it went two weeks without a reply since it was labeled "Can Close?"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? We will close this in 30 days if there is no further activity
Projects
None yet
Development

No branches or pull requests

1 participant