Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to stardoc #715

Closed
gregmagolan opened this issue Apr 22, 2019 · 1 comment
Closed

Update to stardoc #715

gregmagolan opened this issue Apr 22, 2019 · 1 comment

Comments

@gregmagolan
Copy link
Collaborator

gregmagolan commented Apr 22, 2019

We're still using skylark_doc to generate some of the documentation here:

skylark_doc(
    name = "docs",
    srcs = [
        "//internal/common:check_bazel_version.bzl",
        "//internal/history-server:history_server.bzl",
        "//internal/http-server:http_server.bzl",
        "//internal/jasmine_node_test:jasmine_node_test.bzl",
        "//internal/node:node.bzl",
        "//internal/node:node_repositories.bzl",
        "//internal/npm_install:npm_install.bzl",
        "//internal/npm_package:npm_package.bzl",
        "//internal/rollup:rollup_bundle.bzl",
    ],
    format = "html",
    site_root = "/rules_nodejs",
    strip_prefix = "internal/",
    # This rule depends on building protoc which is annoying and slow
    # we only need to build it when we cut a release.
    tags = ["manual"],
)

and in a few other spots.

With Bazel 0.24.1 repository_rule now supports the doc attribute which was blocking this upgrade.

With the update to skydoc we can also re-enable the no-effect buildifier check since it will fix this issue with using the doc attribute in repository_rule and rule which is currently blocked by this issue bazelbuild/buildtools#471 (comment), which should be fixed by updating to skydoc bazelbuild/buildtools#471 (comment)

@alexeagle
Copy link
Collaborator

was fixed in 778c32c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants