Skip to content

Commit

Permalink
Add QNX and OSX to known platforms (#1853)
Browse files Browse the repository at this point in the history
<!-- Thanks for sending a PR! Before submitting:

1. If this is your first PR, please read CONTRIBUTING.md and sign the
CLA
   first. We cannot review code without a signed CLA.
2. Please file an issue *first*. All features and most bug fixes should
have
an associated issue with a design discussed and decided upon. Small bug
   fixes and documentation improvements don't need issues.
3. New features and bug fixes must have tests. Documentation may need to
be updated. If you're unsure what to update, send the PR, and we'll
discuss
   in review.
-->

**What type of PR is this?**

> Uncomment one line below and remove others.
>
Bug fix

**What package or component does this PR mostly affect?**

language/go
cmd/gazelle

**What does this PR do? Why is it needed?**

Adding more known platforms to avoid issue reported in
#1735.

**Which issues(s) does this PR fix?**

Fixes #1735

**Other notes for review**
  • Loading branch information
hofbi authored Aug 6, 2024
1 parent cfe9e8f commit 32de0bd
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
6 changes: 6 additions & 0 deletions language/go/testdata/cgolib_with_build_tags/BUILD.want
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,15 @@ go_library(
"@io_bazel_rules_go//go/platform:openbsd": [
"example.com/repo/lib/deep",
],
"@io_bazel_rules_go//go/platform:osx": [
"example.com/repo/lib/deep",
],
"@io_bazel_rules_go//go/platform:plan9": [
"example.com/repo/lib/deep",
],
"@io_bazel_rules_go//go/platform:qnx": [
"example.com/repo/lib/deep",
],
"@io_bazel_rules_go//go/platform:solaris": [
"example.com/repo/lib/deep",
],
Expand Down
8 changes: 8 additions & 0 deletions rule/platform.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,14 @@ var KnownPlatforms = []Platform{
{"openbsd", "amd64"},
{"openbsd", "arm"},
{"openbsd", "arm64"},
{"osx", "386"},
{"osx", "amd64"},
{"osx", "arm"},
{"osx", "arm64"},
{"qnx", "386"},
{"qnx", "amd64"},
{"qnx", "arm"},
{"qnx", "arm64"},
{"plan9", "386"},
{"plan9", "amd64"},
{"plan9", "arm"},
Expand Down

0 comments on commit 32de0bd

Please sign in to comment.