Allow splitting: gazelle_dependencies() into 2 phases by caller. #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gazelle_init() - gazelle_go_repositories() Thanks to it, the caller can call go_repository in between, loading their own (likely newer) version of the dependencies. Currently `go_repository` cannot be called before `gazelle_dependencies`, as the `bazel_gazelle_go_repository_cache` is not yet initialized. Fixes problems like: - bazel-contrib#1582 - bazel-contrib#1468 - bazel-contrib#1305 -
Can you create a mini-repo for this? All of Uber's go_repositories are loaded before gazelle_dependencies and it works |
|
Couldn't repro. I'm sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow splitting: gazelle_dependencies() into 2 phases by caller:
Thanks to it, the caller can call go_repository in between, loading their own (likely newer) version of the dependencies.
Currently
go_repositorycannot be called beforegazelle_dependencies, as thebazel_gazelle_go_repository_cacheis not yet initialized.Fixes problems like:
What type of PR is this?
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #1305
Other notes for review