Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaInfo starlark constructor doesn't fill compilation_info member #10170

Closed
ittaiz opened this issue Nov 5, 2019 · 8 comments
Closed

JavaInfo starlark constructor doesn't fill compilation_info member #10170

ittaiz opened this issue Nov 5, 2019 · 8 comments
Assignees
Labels
area-java-Starlark_API java_common, JavaInfo and other Starlark Java modules P2 We'll consider working on this in future. (Assignee optional) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Java Issues for Java rules type: bug

Comments

@ittaiz
Copy link
Member

ittaiz commented Nov 5, 2019

Description of the problem / feature request:

JavaInfo instances created from starlark have a None value in compilation_info

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

bazelbuild/rules_scala#872

What's the output of bazel info release?

1.1.0

Any other information, logs, or outputs that you want to share?

Two important notes:

  1. This is blocking moving IntelliJ plugin to use JavaInfo provider instead of the scala attribute.
    https://github.com/bazelbuild/intellij/blob/master/aspect/intellij_info_impl.bzl#L505
    https://github.com/bazelbuild/intellij/blob/master/aspect/java_classpath.bzl#L22
  2. This also means incompatible_disable_target_provider_fields: disallow access of providers on "target" objects by field syntax #9014 is blocked since we can't move to providers without IntelliJ support and I think they need the compilation_info member for that (but I might be wrong). cc @brendandouglas as an expert of whether or not IJ can use other data from the JavaInfo provider is compilation_info is None
@ittaiz
Copy link
Member Author

ittaiz commented Nov 5, 2019

cc @iirina

@ittaiz
Copy link
Member Author

ittaiz commented Nov 5, 2019

I took a look and it's not actually blocking the move to attribute since IJ can just use target[JavaInfo].transitive_runtime_jars for now

@brendandouglas
Copy link
Contributor

+1 -- this is important for IntelliJ support (and for any non-native java rules). We'll workaround it in the short-term, but I think it's very important to fix this on the Bazel side.

@aiuto aiuto added team-Rules-Java Issues for Java rules untriaged labels Nov 6, 2019
@ittaiz
Copy link
Member Author

ittaiz commented Nov 13, 2019

@aiuto @iirina any ideas when this will be triaged?

@comius comius added P2 We'll consider working on this in future. (Assignee optional) area-java-Starlark_API java_common, JavaInfo and other Starlark Java modules and removed untriaged labels Nov 20, 2020
@comius comius self-assigned this Nov 20, 2020
@suman-ganta
Copy link

Ran into this. Wondering if this is being addressed?

@comius
Copy link
Contributor

comius commented Aug 25, 2021

It is, see https://docs.google.com/document/d/10isTEK5W9iCPp4BIyGBrLY5iti3Waaam6EeGVSjq3r8/edit
compilation_info is being removed from JavaInfo, as far as I know IntelliJ aspect is already not using it.

@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label May 24, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-java-Starlark_API java_common, JavaInfo and other Starlark Java modules P2 We'll consider working on this in future. (Assignee optional) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Java Issues for Java rules type: bug
Projects
None yet
Development

No branches or pull requests

6 participants