Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Bazel Docs: Broken Link to "Building with Platforms" #14979

Closed
cpsauer opened this issue Mar 7, 2022 · 3 comments
Closed

New Bazel Docs: Broken Link to "Building with Platforms" #14979

cpsauer opened this issue Mar 7, 2022 · 3 comments
Assignees
@fweikert
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels type: bug untriaged

Comments

@cpsauer
Copy link
Contributor

cpsauer commented Mar 7, 2022 •
edited
Loading

Hey, wonderful Bazel folks,

I was browsing the platform docs, and noticed that the link to the new docs was broken for https://docs.bazel.build/versions/main/platforms-intro.html.

The broken link is https://bazel.build/concepts/platform-intro

Filed a quick PR (#14978) for the other small issue I saw on that page; but figured I should give a friendly heads on this one because I don't know exactly how the new docs system works.

Thanks so much for all you do!
Chris
(ex-Googler)
@gregestren
Copy link
Contributor

Oh that's funny. I independently discovered that while triaging #14982 and now come to this bug.

The problem is it should be plural platforms-intro: https://bazel.build/concepts/platforms-intro. I haven't been able to figure out where that link gets set but @fweikert will know.

@gregestren gregestren added untriaged team-Documentation Documentation improvements that cannot be directly linked to other team labels type: bug labels Mar 7, 2022
@cpsauer cpsauer changed the title New Bazel Docs: Broken Link to "Building with Platforms". Missing? New Bazel Docs: Broken Link to "Building with Platforms" Mar 7, 2022
@fweikert
Copy link
Member

fweikert commented Mar 7, 2022

Hey Chris,

Thank you for the report! I just fixed it.

@fweikert fweikert closed this as completed Mar 7, 2022
@cpsauer
Copy link
Contributor Author

cpsauer commented Mar 7, 2022

You're very welcome. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fweikert fweikert

Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels type: bug untriaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregestren @cpsauer @fweikert