Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the error message when concurrent modification occurs with --experimental_guard_against_concurrent_changes enabled #17173

Closed
tbaing opened this issue Jan 9, 2023 · 1 comment
Assignees
Labels
bad error messaging Issues where users get stuck because they don't understand what they did wrong team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request untriaged

Comments

@tbaing
Copy link
Contributor

tbaing commented Jan 9, 2023

Description of the feature request:

The logging that occurs when concurrent modification of output files occurs when --experimental_guard_against_concurrent_changes is specified didn't jump out to me as the explanation for why my outputs weren't being uploaded to the remote cache. Adding a bit more explanation to the error message would have helped me identify the connection between these things, and is especially important since the plan is to make that flag the default behavior in a future version.

What underlying problem are you trying to solve with this feature?

It wasn't obvious to me that the warning about a file that was modified during the build was the reason my build artifacts weren't being uploaded to the remote cache.

Which operating system are you running Bazel on?

gLinux

What is the output of bazel info release?

experimental_guard_against_concurrent_changes

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

https://github.com/bazelbuild/bazel.git
f2cdf9e65eadfb5365127eabcc72dedce7781405
06deebfb5b73f848de5a0ea0e00fcfaa26788d1f

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@sgowroji sgowroji added team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request bad error messaging Issues where users get stuck because they don't understand what they did wrong untriaged labels Jan 10, 2023
@coeuvre
Copy link
Member

coeuvre commented Jan 12, 2023

Fixed by #17174.

@coeuvre coeuvre closed this as completed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad error messaging Issues where users get stuck because they don't understand what they did wrong team-Remote-Exec Issues and PRs for the Execution (Remote) team type: feature request untriaged
Projects
None yet
Development

No branches or pull requests

3 participants