Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: enable symlink support by default #8704

Closed
laszlocsomor opened this issue Jun 24, 2019 · 6 comments
Closed

Windows: enable symlink support by default #8704

laszlocsomor opened this issue Jun 24, 2019 · 6 comments
Labels
area-Windows Windows-specific issues and feature requests P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request

Comments

@laszlocsomor
Copy link
Contributor

Windows 10 version 1703 (Creators Update) brought unprivileged symlink support to Windows. (After enabling Developer Mode.)

It might be time to enable symlink support in Bazel on Windows by default.
Bazel could possibly also detect if symlinks are supported (i.e. try to create one) and fall back to no support if that failed.

Version: 0.26.0

@laszlocsomor laszlocsomor added P3 We're not considering working on this, but happy to review a PR. (No assignee) area-Windows Windows-specific issues and feature requests type: feature request labels Jun 24, 2019
@jimevans
Copy link

One other possible way to do this would be to check the registry. In pseudo-code:

if (registry key `HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\AppModelUnlock` exists):
  if (DWORD registry value `AllowDevelopmentWithoutDevLicense` exists in the key and the value is not 0):
    return true

return false

@laszlocsomor
Copy link
Contributor Author

Duplicate issue: #7954

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@rickeylev
Copy link
Contributor

It's been several years since this was filed. Are there plans to enable, or known blockers to enabling, symlinks on windows? Some light searching seems to indicate Windows has had this support for many years; perhaps long enough has passed that whatever versions had a problem aren't really supported anymore?

In particular, i found #5807 which seems to indicate several language rules enable symlinks on windows. And the bazel docs seem to recommend enabling it (while simultaneously warning not to because they're "expensive").

In any case, it's looking like rules_python will join the set of rules that requires them to be enabled.

cc @meteorcloudy (seems he was active on 5807, and it doesn't look like there are any current bazel members on this issue)

@meteorcloudy
Copy link
Member

Note that, here symlink actually means "file symlink", we use junction for directory symlink on Windows, it has always been working.

But for creating file symlinks, the user still requires admin right (to run bazel or to enable developer mode). We don't want to add this hard requirement for Bazel users.

Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Dec 18, 2023
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please post @bazelbuild/triage in a comment here and we'll take a look. Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Windows Windows-specific issues and feature requests P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants