Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut all dependencies on bash [duplicate of #4319] #931

Closed
lberki opened this issue Feb 18, 2016 · 5 comments
Closed

Cut all dependencies on bash [duplicate of #4319] #931

lberki opened this issue Feb 18, 2016 · 5 comments
Labels
Milestone

Comments

@lberki
Copy link
Contributor

lberki commented Feb 18, 2016

This will be a "death of a thousand cuts" kind of thing, because we probably use tiny little shell scripts all over the place.

@damienmg damienmg added type: feature request P2 We'll consider working on this in future. (Assignee optional) labels Feb 18, 2016
@davidzchen
Copy link
Member

What exactly is the scope of this? Is it mostly limited to non-test code? Will we have a separate set of shell tests on Windows that run on either powershell or cmd.exe?

Also, what are the implications of Windows support on the sh_* rules?

@lberki
Copy link
Contributor Author

lberki commented Feb 19, 2016

Yes :)

We haven't really figured out yet what we'll do about this. My hunch is that sh_* rules will stay the same, and they will simply not work on Windows for the time being.

@johnynek
Copy link
Member

johnynek commented Mar 1, 2016

why not just ship a bash as part of bazel that can be used on windows and consider bash to be part of the standard tools? There seem to be a few possibilities.

It would be really nice if skylark rules can assume a working bash and a minimal set of tools (unzip, find, zip, ...)

@dslomov dslomov added this to the 0.6 milestone Dec 8, 2016
@dslomov dslomov modified the milestones: 0.7, 0.6 Jul 24, 2017
@dslomov dslomov added P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) labels Jul 24, 2017
@laszlocsomor
Copy link
Contributor

laszlocsomor commented Dec 13, 2017

I envision Bash support via a local repository.
Also I'd like Bazel to depend on Bash only if you try to build sh_* rules (or depend on labels under the make-believe @local_sh_config// repo).

@laszlocsomor laszlocsomor changed the title Cut all dependencies on bash Cut all dependencies on bash [duplicate of #4319] Mar 28, 2018
@laszlocsomor
Copy link
Contributor

Duplicate of #4319

@laszlocsomor laszlocsomor marked this as a duplicate of #4319 Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants